Having just had to deal with two huge photo and slide collections of deceased relatives, I would say:
- make it easy for those who come after you before you die, by organizing or tossing
- digitize the good stuff, drop it onto a family web site, give due consideration to the rapid pace of evolution of digital file formats
- don't expect your successors to expend any amount of effort on the project unless it is trivial